Mike. That's a bit of a bastard of a thing to happen. I have just ordered some so hope I don't have any problems when I get them. Coming from Oz at the moment seems dicey. Hope someone who has them can chip in here and help you set the adjustments right. Any suggestions David!
I am not David, but here is what I would ask, and some of the answers.
So why did Mike have tank slappers?
It is possible that there was a problem with the shocks, not made correctly etc, but I would call that very unlikely.
So what causes "tank Slappers"?
Instability, usually set off by little weight on the front such as a wheelie of hitting a bump.
Why did it start when the shocks were changed? What can change stability?
Rear Ride height.
It is possible even if the shocks were the same length, the springs or the preload on the springs may have been More than the stock shocks.
Causing the rear ride height to increase.
Any increase to the rear ride height is a decrease in trail. Trail is the biggest factor in determining stability.
In Mike's case, as far as we know, only the shocks were changed.
Before installing the new shocks I would measure the static sag and the rider sag.
Start with the new shocks at the same rider sag. Which is adjusted by the preload on the springs.
Of course check the the new shocks are the same length as the OEM shocks, you can either measure them, or install them one at a time, with the one stock shock still in place, the new shock should mount up with ease if it is the same length.
After riding with the rider sag set the same as the stock shock, if all is OK, I would try and set the rider sag at 30 mm.
After the rider sag is set to 30 mm check the static sag, it should be between 5 and 15 mm.
As to the springs being infinitely adjustable, that may be true based on the amount of threaded area, but you should keep the installed preload between 10 and 35 mm. If you are having to use any more or less it means you should have a different spring rate.
Hope that helps.